chore: Add UI linter back#3230
Merged
franciscojavierarceo merged 3 commits intoAug 22, 2025
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
franciscojavierarceo
force-pushed
the
precommit-ui-linter
branch
2 times, most recently
from
0b56aa7 to
9c77fe8
Compare
Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
franciscojavierarceo
force-pushed
the
precommit-ui-linter
branch
from
9c77fe8 to
e27acc3
Compare
franciscojavierarceo
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
franciscojavierarceo
added a commit
to franciscojavierarceo/llama-stack
that referenced
this pull request
Aug 25, 2025
# What does this PR do? 1. Adds `scripts/run-ui-linter.sh` - Light script that checks whether `node_modules`,`eslint`, and `prettier` exist before running linter - When I introduced [the linter for the UI](https://github.com/llamastack/llama-stack/pull/3156/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9) it forced the UI linter on all users, the small `node_modules` check means that only users that have installed the UI locally (since `node_modules` is in the gitignore) will actually end up having this run. Additionally this does not do any install and just runs the existing linter/prettier as requested by @mattf 2. Updates `.github/workflows/pre-commit.yml` to run CI again - When I introduced the UI linter in the CI [in this PR](ogx-ai#3191) a failure occurred because dependabot needed to be updated to also bump the `package-lock.json` which was done [in this PR](ogx-ai#3212). All of this to say, we shouldn't observe failures from dependabot again. 3. Updates `.pre-commit-config.yaml` - Calls `scripts/run-ui-linter.sh` ## AI Assistance Notice I used Copilot minimally. ## Test Plan As [requested](ogx-ai#3207 (comment)) by @mattf I ran this after removing all of my `node_modules` and the linter passed. Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
scripts/run-ui-linter.shnode_modules,eslint, andprettierexist before running linternode_modulescheck means that only users that have installed the UI locally (sincenode_modulesis in the gitignore) will actually end up having this run. Additionally this does not do any install and just runs the existing linter/prettier as requested by @mattf.github/workflows/pre-commit.ymlto run CI againpackage-lock.jsonwhich was done in this PR. All of this to say, we shouldn't observe failures from dependabot again..pre-commit-config.yamlscripts/run-ui-linter.shAI Assistance Notice
I used Copilot minimally.
Test Plan
As requested by @mattf I ran this after removing all of my
node_modulesand the linter passed.